Skip to content

[Android] Take 2 on this issue: The latest Android 16 update broke the update for the Search and Favorites widget #6885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[Android] Take 2 on this issue: The latest Android 16 update broke the update for the Search and Favorites widget #6885

wants to merge 3 commits into from

Conversation

anikiki
Copy link
Contributor

@anikiki anikiki commented Oct 3, 2025 •
edited
Loading

Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1211543179581893

Description

This PR brings back the initial changes made as part of https://app.asana.com/1/137249556945/project/1202552961248957/task/1211451449729774 and fixes the issue for old OS versions.

Steps to test this PR

Test the Search and Favorites widget on OS versions like: 8, 9 , 10, 11, 12

@anikiki Graphite App
Copy link
Contributor Author

anikiki commented Oct 3, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@anikiki anikiki changed the title Revert "Revert "[Android] The latest Android 16 update broke the update for the Search and Favorites widget (#6843)" (#6883)" [Android] Take 2 on this issue: The latest Android 16 update broke the update for the Search and Favorites widget Oct 3, 2025
@anikiki anikiki marked this pull request as ready for review October 3, 2025 12:01
@0nko 0nko self-assigned this Oct 3, 2025
0nko
0nko approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on multiple Android versions, including API 26 and it's working! 🎉

@landomen, do you want to give it a try on your phone?

@landomen
Copy link
Contributor

landomen commented Oct 3, 2025 •
edited
Loading

@anikiki @0nko It's still crashing on my S10 (Android 12) with 24dp size (84px). Anything over 14dp (50px, 10kb) is crashing. However, at 14dp the image quality is pretty poor, but still passable. I'm worried that while 14dp works on my phone, it might not work on an older phone like the S7 which is one of the crash reports.

Should we go with 14dp and see how if it fixes the issue for all devices? Or invest more time in finding an alternative solution?

One idea that comes to mind is continuing @0nko's workaround of using URIs, but also supporting it for the generated avatars by storing it to disk and then using URI for that as well. Not sure if it would work, but worth a try.

Screenshot_20251003_173559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0nko 0nko 0nko approved these changes

Assignees

@0nko 0nko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anikiki @landomen @0nko